-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add splashscreens member + purpose (closes #510) #530
Conversation
37fc824
to
c332028
Compare
<p> | ||
When showing a <a>splash screen</a>, a user agent MUST announce to | ||
assistive technologies that the web application is being loaded in | ||
the background. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This general statement of intent looks good to me. Is this intended to mean the UA automatically announces this? I'm assuming in its current form, an app can't use the splash screen to show additional information (e.g. short status/progress messages of what it's loading/doing - e.g. "reticulating splines 67%" or similar ? Otherwise this would also need to be taken into account (and at that stage, it's more likely that authors will want/need to control what exactly is exposed to AT, e.g. using an aria-live
region...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"a user agent MUST announce to assistive technologies" is unclear, suggest something in form of "users agents MUST expose the loading state of the application via the platform <a>
Accessibility API</a>
(s)"
latest changes lgtm |
@kenchris, thanks for checking. Waiting on @mounirlamouri, who originally requested this. |
Sorry, I entirely missed track of this. What's the benefit of adding a member and a purpose? |
@marcoscaceres can you answer @mounirlamouri 's question? |
Rather than adding another object to the Manifest, what about just adding guidance for developers to include full screen sized icons on the icons[ ] object? |
Icons and splash screens are different things tho. |
@marcoscaceres That's definitely true; but if there is no splash screen, a larger icon centered on a background seems to be a common splash screen used by developers. (This seems to be what Twitter and LinkedIn apps do.) Rather than adding another object (which I'm hesitant to do since we don't want Manifests to be too complex), I'm thinking if we just encourage larger images in the |
We need to solve images... Like with masking for round icons etc or the icons cannot be reused. The current situation leads to weird UX like Twitter Lite on the Pixel |
Yes that proposal fixes the issues that I mentioned about Twitter Lite and the Pixel |
On iOS 11.3 Beta 2, Apple apparently do not follow the Chrome convention (hack?) of creating a splashscreen. However, Apple have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commenting to inform of a few minor typos. thanks for working on this 👍
A <dfn>splash screen</dfn> is a graphical representation (usually an | ||
image on a background color) that is presented as the end user before | ||
the user agent is able render content. A splash screen is intended to | ||
convey to the end-user that the web application is being prepared for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end-user
is end user
above. can you choose the same one to be consistent?
<code>splashscreens</code> member | ||
</h3> | ||
<p> | ||
A <dfn>splash screen</dfn> is a graphical representation (usually an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this read splashscreens
instead of splash screen
?
the other member sections start like this. is that an issue
<p> | ||
A <dfn>splash screen</dfn> is a graphical representation (usually an | ||
image on a background color) that is presented as the end user before | ||
the user agent is able render content. A splash screen is intended to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few typos caught:
presented as the end user
->presented to the end user
is able render
→is able to render
I wonder when the UA decide to change the screen from splash screen to main page. |
No description provided.