Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add splashscreens member + purpose (closes #510) #530

Closed
wants to merge 2 commits into from

Conversation

marcoscaceres
Copy link
Member

No description provided.

@marcoscaceres marcoscaceres changed the title feat: Add splashscreens member + purpose (closes #501) feat: Add splashscreens member + purpose (closes #510) Nov 18, 2016
<p>
When showing a <a>splash screen</a>, a user agent MUST announce to
assistive technologies that the web application is being loaded in
the background.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This general statement of intent looks good to me. Is this intended to mean the UA automatically announces this? I'm assuming in its current form, an app can't use the splash screen to show additional information (e.g. short status/progress messages of what it's loading/doing - e.g. "reticulating splines 67%" or similar ? Otherwise this would also need to be taken into account (and at that stage, it's more likely that authors will want/need to control what exactly is exposed to AT, e.g. using an aria-live region...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a user agent MUST announce to assistive technologies" is unclear, suggest something in form of "users agents MUST expose the loading state of the application via the platform <a>Accessibility API</a>(s)"

@kenchris
Copy link
Collaborator

latest changes lgtm

@marcoscaceres
Copy link
Member Author

@kenchris, thanks for checking. Waiting on @mounirlamouri, who originally requested this.

@mounirlamouri
Copy link
Member

Sorry, I entirely missed track of this. What's the benefit of adding a member and a purpose?

@kenchris
Copy link
Collaborator

kenchris commented Feb 9, 2017

@marcoscaceres can you answer @mounirlamouri 's question?

@RobDolinMS
Copy link
Contributor

Rather than adding another object to the Manifest, what about just adding guidance for developers to include full screen sized icons on the icons[ ] object?

@marcoscaceres
Copy link
Member Author

Icons and splash screens are different things tho.

@RobDolinMS
Copy link
Contributor

Icons and splash screens are different things tho.

@marcoscaceres That's definitely true; but if there is no splash screen, a larger icon centered on a background seems to be a common splash screen used by developers. (This seems to be what Twitter and LinkedIn apps do.)

Rather than adding another object (which I'm hesitant to do since we don't want Manifests to be too complex), I'm thinking if we just encourage larger images in the icons[ ] array, this gives advanced web app developers a way to specify desired images to use for splashscreens; and gives new web app developers a good result from a simple manifest.

@kenchris
Copy link
Collaborator

kenchris commented May 2, 2017

We need to solve images... Like with masking for round icons etc or the icons cannot be reused. The current situation leads to weird UX like Twitter Lite on the Pixel

@marcoscaceres
Copy link
Member Author

@kenchris, doest your adaptive icon proposal #563 solve the problem?

@kenchris
Copy link
Collaborator

kenchris commented May 5, 2017

Yes that proposal fixes the issues that I mentioned about Twitter Lite and the Pixel

@tomayac
Copy link
Contributor

tomayac commented Feb 14, 2018

On iOS 11.3 Beta 2, Apple apparently do not follow the Chrome convention (hack?) of creating a splashscreen. However, Apple have a meta tag for the old-school iOS Web apps (documentation). The iOS Human Interface Guidelines have up-to-date (including iPhone X) specs for the dimensions.

Copy link
Contributor

@cvan cvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commenting to inform of a few minor typos. thanks for working on this 👍

A <dfn>splash screen</dfn> is a graphical representation (usually an
image on a background color) that is presented as the end user before
the user agent is able render content. A splash screen is intended to
convey to the end-user that the web application is being prepared for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end-user is end user above. can you choose the same one to be consistent?

<code>splashscreens</code> member
</h3>
<p>
A <dfn>splash screen</dfn> is a graphical representation (usually an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this read splashscreens instead of splash screen?

the other member sections start like this. is that an issue

<p>
A <dfn>splash screen</dfn> is a graphical representation (usually an
image on a background color) that is presented as the end user before
the user agent is able render content. A splash screen is intended to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few typos caught:

  • presented as the end user -> presented to the end user
  • is able renderis able to render

@DongHyunSong
Copy link

I wonder when the UA decide to change the screen from splash screen to main page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants